Skip to content
#

react-router

Here are 6,066 public repositories matching this topic...

danielo515
danielo515 commented Jan 16, 2020

I'm not sure in which repository should open this kind of issues so I just open it on the main one, but you can point me to the correct one any time.

I noticed that rekit uses (or pretends to use) prettier as code formatter.
You should rather include it in the package.json of the template as a dependency o explain on the documentation that it is an opt-in feature and that it should be installe

R10burning
R10burning commented Apr 16, 2020

import React, { Component } from 'react'
import { connect } from 'react-redux'
import { test } from '@/actions/common'
import store from '@/store'
import { push } from 'connected-react-router'
import PropTypes from 'prop-types'
@connect((state) => ({ home: state.home }), { test })
class Home extends Component {
static propTypes = {
test: PropTypes.func.isRequired
}
componentDi

choonkending
choonkending commented Dec 29, 2016

We have a lot of comments that we added in when the repository was created.

In many cases, we should either write self-documenting code, as comments are at best, a necessary evil.

If we cannot change the function/variable names to be self-explanatory, we should consider extracting that into README.

mininternet
mininternet commented Feb 9, 2018

@diegohaz - i noticed a couple of minor spelling errors on the main site:

Basic stack
It includes everything necessary to build a tipical web app with focus on productivity and developer experience.
Learn more about the recomended workflow

Should be typical, and recommended.

Just an FYI.

Thanks!

dlong500
dlong500 commented Sep 27, 2017

I'm trying to migrate from v1 to v2 of redux-auth-wrapper. I'm sticking with RR3 for the moment since I'm using SSR and it will be a larger undertaking to migrate everything to RR4 (though I do want to migrate eventually).

That being said, I'm running into some issues with getting everything working like it was under v1. To summarize, I'm not sure how to get a FailureComponent working under v

dmliao
dmliao commented Oct 6, 2018

The API docs reference the function store.getState() multiple times, but doesn't provide any documentation on how to obtain the store object to call that function.

I found through trial and error that you can access the store object in the following manner:

import { store } from 'mirrorx/lib/store';
...
store.getState();

This information should probably exist in the API pa

Improve this page

Add a description, image, and links to the react-router topic page so that developers can more easily learn about it.

Curate this topic

Add this topic to your repo

To associate your repository with the react-router topic, visit your repo's landing page and select "manage topics."

Learn more

You can’t perform that action at this time.