Thanks, using integers for the resampling is why I actually included a copy of the old resampling code from FFmpeg in the repo, so having avresample/swresample using floating point was definitely not intentional.

However, this should be also done for libavresample, not just libswresample, to make sure these are consistent. It's probably better to use the full internal_sample_fmt option name for both.

I'm also not sure about the planar format. We want non-planar format out of it in the end. Can you try if it's not even after with AV_SAMPLE_FMT_S16?

AV_SAMPLE_FMT_S16 isn't supported. I think this is because internally the resampler works on a single channel at a time, so it makes sense that it wouldn't support an interleaved format as the internal format.

I'll do the rename and make the change in libavresample.

Hey there, any chances of this ever being merged?

Yes, but there are still some changes to be made. And it needs to be properly tested with both ffmpeg and libav.

@agentsim ping ?

@Seluj78 The project I'm working on moved to beefier hardware where this fix is not important, so I have not had the time to finish it up.

@agentsim sure thing, I was just wondering :)