Skip to content

/ xarray

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use flake8 rather than pycodestyle #3010

Merged
merged 13 commits into from Jun 12, 2019
Merged

Use flake8 rather than pycodestyle #3010

merged 13 commits into from Jun 12, 2019

Conversation

@max-sixty
Copy link
Collaborator

@max-sixty max-sixty commented Jun 10, 2019 •
edited

  • Closes #2990
  • Fully documented, including whats-new.rst for all changes and api.rst for new API

I also ran isort, which created more changes that I would have hoped. Lmk if that's OK.
We could also enable isort by default. It's a balance: it reduces the chance of merge conflicts and adds automatic consistency, but at the cost of making first-time contributions a bit more difficult.
max-sixty added 6 commits Jun 10, 2019
@max-sixty
A few flake fixes
Verified
This commit was signed with a verified signature.
max-sixty Maximilian Roos
GPG key ID: 3232F28BEDA66FCD Learn about signing commits
82ce083
@max-sixty
isort
Verified
This commit was signed with a verified signature.
max-sixty Maximilian Roos
GPG key ID: 3232F28BEDA66FCD Learn about signing commits
2513233
@max-sixty
bunch of flake8 errors fixed
Verified
This commit was signed with a verified signature.
max-sixty Maximilian Roos
GPG key ID: 3232F28BEDA66FCD Learn about signing commits
5217759
@max-sixty
flake8 config
Verified
This commit was signed with a verified signature.
max-sixty Maximilian Roos
GPG key ID: 3232F28BEDA66FCD Learn about signing commits
47b6488
@max-sixty
pep8speaks config
Verified
This commit was signed with a verified signature.
max-sixty Maximilian Roos
GPG key ID: 3232F28BEDA66FCD Learn about signing commits
68a923a
@max-sixty
run flake8 in travis
Verified
This commit was signed with a verified signature.
max-sixty Maximilian Roos
GPG key ID: 3232F28BEDA66FCD Learn about signing commits
Loading status checks…
fbbeac9
@max-sixty
Copy link
Collaborator Author

@max-sixty max-sixty commented Jun 10, 2019

Also fixes #2833
@max-sixty
docs to flake8
Verified
This commit was signed with a verified signature.
max-sixty Maximilian Roos
GPG key ID: 3232F28BEDA66FCD Learn about signing commits
Loading status checks…
1316894
@max-sixty max-sixty force-pushed the max-sixty:flake8 branch from fdee5ba to 1316894 Jun 10, 2019
@pep8speaks
Copy link

@pep8speaks pep8speaks commented Jun 10, 2019 •
edited

Hello @max-sixty! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 58:1: E265 block comment should start with '# '
Line 97:1: E265 block comment should start with '# '
Line 117:1: E265 block comment should start with '# '
Line 121:1: E265 block comment should start with '# '
Line 131:1: E265 block comment should start with '# '
Line 134:1: E265 block comment should start with '# '
Line 138:1: E265 block comment should start with '# '
Line 142:1: E265 block comment should start with '# '
Line 148:1: E265 block comment should start with '# '
Line 151:1: E265 block comment should start with '# '
Line 168:1: E265 block comment should start with '# '
Line 172:1: E265 block comment should start with '# '
Line 175:1: E265 block comment should start with '# '
Line 195:44: E231 missing whitespace after ','
Line 195:51: E231 missing whitespace after ','
Line 202:1: E265 block comment should start with '# '
Line 210:1: E265 block comment should start with '# '
Line 213:1: E265 block comment should start with '# '
Line 217:1: E265 block comment should start with '# '
Line 220:1: E265 block comment should start with '# '
Line 226:1: E265 block comment should start with '# '
Line 229:1: E265 block comment should start with '# '
Line 232:1: E265 block comment should start with '# '
Line 235:1: E265 block comment should start with '# '
Line 240:1: E265 block comment should start with '# '
Line 243:1: E265 block comment should start with '# '
Line 252:1: E122 continuation line missing indentation or outdented
Line 253:1: E122 continuation line missing indentation or outdented
Line 253:1: E265 block comment should start with '# '
Line 255:1: E122 continuation line missing indentation or outdented
Line 256:1: E122 continuation line missing indentation or outdented
Line 256:1: E265 block comment should start with '# '
Line 258:1: E122 continuation line missing indentation or outdented
Line 259:1: E122 continuation line missing indentation or outdented
Line 259:1: E265 block comment should start with '# '
Line 266:3: E121 continuation line under-indented for hanging indent
Line 272:1: E265 block comment should start with '# '
Line 276:1: E265 block comment should start with '# '
Line 279:1: E265 block comment should start with '# '
Line 282:1: E265 block comment should start with '# '
Line 285:1: E265 block comment should start with '# '
Line 288:1: E265 block comment should start with '# '
Line 301:1: E265 block comment should start with '# '
Line 310:3: E121 continuation line under-indented for hanging indent
Line 316:1: E265 block comment should start with '# '
Line 319:1: E265 block comment should start with '# '
Line 322:1: E265 block comment should start with '# '
Line 325:1: E265 block comment should start with '# '

Comment last updated at 2019-06-12 04:20:28 UTC
@max-sixty
pep8speaks configs inherited from setup.cfg
Verified
This commit was signed with a verified signature.
max-sixty Maximilian Roos
GPG key ID: 3232F28BEDA66FCD Learn about signing commits
Loading status checks…
4a74c9a
@max-sixty max-sixty mentioned this pull request Jun 10, 2019
Open
max-sixty added 3 commits Jun 10, 2019
@max-sixty
too much isort, skipped base __init__
Verified
This commit was signed with a verified signature.
max-sixty Maximilian Roos
GPG key ID: 3232F28BEDA66FCD Learn about signing commits
Loading status checks…
67e8a5f
@max-sixty
imports
Verified
This commit was signed with a verified signature.
max-sixty Maximilian Roos
GPG key ID: 3232F28BEDA66FCD Learn about signing commits
Loading status checks…
d841273
@max-sixty
install flake8 in travis
Verified
This commit was signed with a verified signature.
max-sixty Maximilian Roos
GPG key ID: 3232F28BEDA66FCD Learn about signing commits
Loading status checks…
61f1abc
@max-sixty
Copy link
Collaborator Author

@max-sixty max-sixty commented Jun 10, 2019

Will wait for a couple of days to see if there's a response on the pep8speaks config issue; otherwise will revert to the existing config.

Tests pass apart from dask-dev which breaks on master
@max-sixty
Merge branch 'master' into flake8
Verified
This commit was signed with a verified signature.
max-sixty Maximilian Roos
GPG key ID: 3232F28BEDA66FCD Learn about signing commits
Loading status checks…
9b9c4da
@max-sixty
Copy link
Collaborator Author

@max-sixty max-sixty commented Jun 11, 2019

This is ready to merge after a review. pep8speaks checks the config in master, and so this needs to be merged in order for the config to be updated
@shoyer
shoyer approved these changes Jun 12, 2019
View changes
Copy link
Member

@shoyer shoyer left a comment

Looks good to me, thank you!
ci/requirements-py37.yml Show resolved Hide resolved
@max-sixty
update 3.6 reqs
Verified
This commit was signed with a verified signature.
max-sixty Maximilian Roos
GPG key ID: 3232F28BEDA66FCD Learn about signing commits
Loading status checks…
aa7400c
@shoyer shoyer merged commit 3429ca2 into pydata:master Jun 12, 2019
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 96.668%
Details
@shoyer
Copy link
Member

@shoyer shoyer commented Jun 12, 2019

Thanks!
@max-sixty max-sixty deleted the max-sixty:flake8 branch Jun 12, 2019
This was referenced Jun 24, 2019
Closed
Closed
dcherian added a commit to dcherian/xarray that referenced this pull request Jun 24, 2019
@dcherian
Merge branch 'master' into fix/bounds_encode_2
f187ca1 
* master: (31 commits)
  Add quantile method to GroupBy (pydata#2828)
  rolling_exp (nee ewm) (pydata#2650)
  Ensure explicitly indexed arrays are preserved (pydata#3027)
  add back dask-dev tests (pydata#3025)
  ENH: keepdims=True for xarray reductions (pydata#3033)
  Revert cmap fix (pydata#3038)
  Add "errors" keyword argument to drop() and drop_dims() (pydata#2994) (pydata#3028)
  More consistency checks (pydata#2859)
  Check types in travis (pydata#3024)
  Update issue templates (pydata#3019)
  Add pytest markers to avoid warnings (pydata#3023)
  Feature/merge errormsg (pydata#2971)
  More support for missing_value. (pydata#2973)
  Use flake8 rather than pycodestyle (pydata#3010)
  Pandas labels deprecation (pydata#3016)
  Pytest capture uses match, not message (pydata#3011)
  dask-dev tests to allowed failures in travis (pydata#3014)
  Fix 'to_masked_array' computing dask arrays twice (pydata#3006)
  str accessor (pydata#2991)
  fix safe_cast_to_index (pydata#3001)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shoyer shoyer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@max-sixty @pep8speaks @shoyer
You can’t perform that action at this time.