Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Byebug requires Ruby 2.2 #3790

Merged
merged 1 commit into from Aug 24, 2017
Merged

Byebug requires Ruby 2.2 #3790

merged 1 commit into from Aug 24, 2017

Conversation

@lildude
Copy link
Member

@lildude lildude commented Aug 22, 2017

The minimum Ruby version required for byebug is now 2.2.0 thanks to deivid-rodriguez/byebug#337. This requirement change has led to our 2.1 builds failing with:

Gem::InstallError: byebug requires Ruby version >= 2.2.0.
Using github-linguist 5.2.0 from source at .
An error occurred while installing byebug (9.1.0), and Bundler cannot continue.
Make sure that `gem install byebug -v '9.1.0'` succeeds before bundling.
The command "eval bundle install --jobs=3 --retry=3 --path=${BUNDLE_PATH:-vendor/bundle} " failed 3 times.
The command "bundle install --jobs=3 --retry=3 --path=${BUNDLE_PATH:-vendor/bundle}" failed and exited with 5 during .
Your build has been stopped.

Rather than locking us to a particular version of byebug, I've bumped the minimum Ruby version to 2.2.0 and I've also defined a :debug group and excluded it in the Travis build so byebug is not installed during testing as it's not needed during testing.

One less gem means a slightly quicker build too 😄

/cc @github/data-engineering

Also don't attempt to install it during testing.
Copy link
Collaborator

@Alhadis Alhadis left a comment

I'm all for a quicker build!

@lildude lildude merged commit b541b53 into master Aug 24, 2017
3 checks passed
3 checks passed
GitHub CLA @lildude has accepted the GitHub Contributor License Agreement.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@lildude lildude deleted the lildude/byebug-requires-ruby-2.2 branch Aug 24, 2017
@lildude lildude mentioned this pull request Oct 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants