Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCertain tests are never called #5704
Comments
|
those tests are passing. i see no problem here... |
|
well datetime-functions file was one example ...
This above one seems to be based on a missed installation dependency, but the next one... ?
does it hurt to run them in CI ... ? they don't take that long ... ? |
That is correct, if you are going to test all exchanges you will also need web3, however, we don't install it by default, it's a responsibility of the user.
The next one is not finished yet: https://github.com/ccxt/ccxt/blob/master/python/test/test_calculate_fee.py#L3 |
node run-testsThe Contributing documentation states to run
node run-testsafternpm run build.This however does only run the main test-file (
test.py/test.php, ...).Files like
test_exchange_datetime_functions.py|test.datetime.jsare not ran (and i did not find any reference on how/when this would ever be running during CI) - so i think these tests are not tested.While this could be intentional (to shorten test-times) - i don't think it is.