Improve documentation around signalling #548

aakilfernandes · 2019-09-17T01:41:44Z

Not a bug but a suggestion:

I think it'd be easier for newbies if trickle was set to false by default. While the examples use clients on a same context and multiple candidates are shared automatically, developers will likely use a signaling server. When building out a signaling server, its not immediately obvious you need to handle multiple signals from the same peer. Setting trickle to false by default would hopefully save a lot of headaches.

t-mullen · 2019-09-17T01:45:00Z

trickle:false won't ensure only a single signal message. If you addStream after negotiation completes, you'll get more messages.

Disabling trickle is kind of terrible - it stalls establishing the connection until ICE fully completes. I don't think poor performance should be the default.

Maybe this is a documentation bug rather than an issue with the defaults?

aakilfernandes · 2019-09-17T02:09:22Z

Thats a fair point. Didn't realize addStream would require additional signaling.

t-mullen added the documentation label Dec 13, 2019

t-mullen changed the title ~~trickle: false as default~~ Improve documentation around signalling Feb 4, 2020

feross / simple-peer

Improve documentation around signalling #548

Improve documentation around signalling #548

aakilfernandes commented Sep 17, 2019 •

edited

t-mullen commented Sep 17, 2019 •

edited

aakilfernandes commented Sep 17, 2019

feross / simple-peer

Sponsor feross/simple-peer

Join GitHub today

Improve documentation around signalling #548

Improve documentation around signalling #548

Comments

aakilfernandes commented Sep 17, 2019 • edited

t-mullen commented Sep 17, 2019 • edited

aakilfernandes commented Sep 17, 2019

aakilfernandes commented Sep 17, 2019 •

edited

t-mullen commented Sep 17, 2019 •

edited