Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upEnable modern event system and delete dead code #19230
Merged
Conversation
codesandbox
bot
commented
Jul 1, 2020
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d04cd4d:
|
| ReactDOM = require('react-dom'); | ||
| Scheduler = require('scheduler'); | ||
| }); | ||
|
|
||
| // @gate experimental | ||
| it('flushes pending interactive work before extracting event handler', () => { | ||
| container = document.createElement('div'); | ||
| const root = ReactDOM.unstable_createRoot(container); | ||
| const root = ReactDOM.createRoot(container); |
This comment has been minimized.
This comment has been minimized.
gaearon
Jul 1, 2020
Author
Member
I didn't change this one. Git just thinks I renamed it whereas I actually deleted old test.
Kind of confusing why it uses unprefixed name. I thought that doesn't work anymore.
sizebot
commented
Jul 1, 2020
Details of bundled changes.Comparing: e3f4eb7...d04cd4d react-dom
react-native-renderer
ReactDOM: size: -24.8%, gzip: -21.7% Size changes (experimental) |
sizebot
commented
Jul 1, 2020
Details of bundled changes.Comparing: e3f4eb7...d04cd4d react-dom
react-native-renderer
ReactDOM: size: -24.8%, gzip: -21.7% Size changes (stable) |
|
It looks good apart from |
|
Hmm. I'm not sure I follow. The native renderer uses the legacy system, right? We don't yet remove pooling on RN either. |
|
Ah , ignore me. I got confused by which file. |
gaearon
merged commit 9fba65e
into
facebook:master
32 checks passed
32 checks passed
ci/circleci: RELEASE_CHANNEL_stable_yarn_test_prod_www_variant
Your tests passed on CircleCI!
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
gaearon commentedJul 1, 2020
•
edited
In #19228, I forked legacy event system folder for DOM and Native.
In this PR, I am removing the
enableModernEventSystemflag altogether:enableModernEventSystem = true.enableModernEventSystem = false.This enables us to remove a bunch of files and codepaths in DOM. There's more to do there but this is already fairly invasive so I will send the rest as follow-ups.
You should review without whitespace. https://github.com/facebook/react/pull/19230/files?diff=split&w=1