Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse a custom jsdom fork #19284
Merged
Use a custom jsdom fork #19284
+6
−3
Conversation
codesandbox
bot
commented
Jul 8, 2020
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5aba707:
|
|
LGTM, will let you decide before landing |
sizebot
commented
Jul 8, 2020
sizebot
commented
Jul 8, 2020
gaearon
merged commit c7805b8
into
facebook:master
29 of 32 checks passed
29 of 32 checks passed
ci/circleci: RELEASE_CHANNEL_stable_yarn_test_prod_www_variant
Your tests passed on CircleCI!
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
gaearon commentedJul 8, 2020
•
edited
This temporarily uses a jsdom fork, which is the version we use + jsdom/jsdom@a52b77b cherry-picked. This should unblock #19186.
This assumes that we actually need this change to unblock. I'm not confident yet because it seems like it affects only createEventHandle tests (?), and that API isn't being used anywhere. So the alternative is just to disable these tests.Misunderstood, ignore me.