This repository has been archived by the owner. It is now read-only.
[FEATURE] Client Certificate authentication #2007
Open
Conversation
|
|
|
|
|
This is excellent news, our reverse proxy server requires users to us a client certificate as part of two factor authentication. This has worked well for web clients, but now we will be able to use mobile devices as well once this change is merged. |
|
@nklock I wouldn't bank on this actually making the cut. You can always generate and release your own app in-house, like we've done. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
@RocketChat/android
Related to #1851
Disclaimer: I am very far removed from being an android or indeed mobile developer, please view this PR as a WIP, I am very open for feedback and changing this in a way that will make it something the Rocket.Chat team would like to merge and support, versus us keeping a local copy and merging in your changes every time.
Changes:
Select Client CertificatebuttonclientCertHelperand various links to this helperIt allows for the app to perform as usual with servers protected behind client certificates.
Known bugs:
/websocketall still seem to fail due to not sending the correct certificate, though I'm unsure of the impact of this. The app seems to perform as usual.Screenshots or GIF for the change:
(blurring is on purpose