Skip to content

/ flink

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-18606][java-streaming] Remove unused generic parameter from SinkFunction.Context #12906

Closed
wants to merge 1 commit into from
Closed

[FLINK-18606][java-streaming] Remove unused generic parameter from SinkFunction.Context #12906

wants to merge 1 commit into from

Conversation

@nielsbasjes
Copy link
Contributor

@nielsbasjes nielsbasjes commented Jul 15, 2020

What is the purpose of the change

The SinkFunction.Context has an unused generic parameter which causes needless warnings in many places.

Brief change log

Remove the type parameter from SinkFunction.Context

Verifying this change

This change is already covered by existing tests.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): yes
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): yes
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
@flinkbot
Copy link

@flinkbot flinkbot commented Jul 15, 2020

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 856e797 (Wed Jul 15 11:33:06 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!
  • This pull request references an unassigned Jira ticket. According to the code contribution guide, tickets need to be assigned before starting with the implementation work.

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier
@flinkbot
Copy link

@flinkbot flinkbot commented Jul 15, 2020 •
edited

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build
@nielsbasjes nielsbasjes force-pushed the nielsbasjes:FLINK-18606-Remove-SinkFunction-Context-generic-parameter branch from 856e797 to 09455c5 Jul 15, 2020
@aljoscha aljoscha self-requested a review Jul 15, 2020
@aljoscha aljoscha self-assigned this Jul 15, 2020
@nielsbasjes
[FLINK-18606][java-streaming] Remove unused generic parameter from Si…
c7da082 
…nkFunction.Context
@nielsbasjes nielsbasjes force-pushed the nielsbasjes:FLINK-18606-Remove-SinkFunction-Context-generic-parameter branch from 09455c5 to c7da082 Jul 21, 2020
@aljoscha
Copy link
Contributor

@aljoscha aljoscha commented Jul 23, 2020

@flinkbot run azure
@aljoscha
Copy link
Contributor

@aljoscha aljoscha commented Jul 23, 2020

This looks good! I'll merge once CI is green.
@nielsbasjes
Copy link
Contributor Author

@nielsbasjes nielsbasjes commented Jul 29, 2020

Seems it failed over a connectivity error (NoHostAvailableException) in relation to Cassandra.
So far I have not been able to link this failure to the changes in this pull request.
@aljoscha
Copy link
Contributor

@aljoscha aljoscha commented Jul 29, 2020

@flinkbot run azure
@nielsbasjes
Copy link
Contributor Author

@nielsbasjes nielsbasjes commented Jul 29, 2020

@aljoscha Thanks. This time it is green.
@aljoscha
Copy link
Contributor

@aljoscha aljoscha commented Jul 29, 2020

Sweet! I'm merging. Thanks for checking this out and fixing it! 👍
@aljoscha
Copy link
Contributor

@aljoscha aljoscha commented Jul 29, 2020

Merged!
@aljoscha aljoscha closed this Jul 29, 2020
@nielsbasjes nielsbasjes deleted the nielsbasjes:FLINK-18606-Remove-SinkFunction-Context-generic-parameter branch Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aljoscha aljoscha

Assignees

@aljoscha aljoscha

Labels
component=<none> review=description?
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@nielsbasjes @flinkbot @aljoscha @rmetzger
You can’t perform that action at this time.