Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Allow to pass command line arguments to dockerized firefox #481
Conversation
jessfraz
merged commit b11b7d2
into
jessfraz:master
2 checks passed
2 checks passed
Fixmie
No improvements found
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Hi I cloned your repo with Docker images some time ago. I wanted to use dockerized Firefox. I also wanted to start dockerized Firefox and pass command line arguments to it (--private-window, --url etc.). I found out that your entrypoint script didn't allow that so I made this simple change.