Skip to content

Removed redundant parser assignment#5152

Merged
justindho merged 1 commit intoaws:developfrom
ChrisAHolland:remove-redundant-parser-assignment
May 20, 2022
Merged

Removed redundant parser assignment#5152
justindho merged 1 commit intoaws:developfrom
ChrisAHolland:remove-redundant-parser-assignment

Conversation

@ChrisAHolland
Copy link
Contributor

@ChrisAHolland ChrisAHolland commented Apr 24, 2020

parser is passed as a parameter when _add_aliases() is called in main(). However, parser is then re-declared on line 145 to the very same thing it is assigned before _add_aliases() is called (line 203).

This PR removes the redundant assignment of parser.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-io
Copy link

codecov-io commented Apr 24, 2020

Codecov Report

Merging #5152 into develop will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5152      +/-   ##
===========================================
- Coverage    93.97%   93.97%   -0.01%     
===========================================
  Files          188      188              
  Lines        14548    14547       -1     
===========================================
- Hits         13672    13671       -1     
  Misses         876      876              
Impacted Files Coverage Δ
awscli/clidriver.py 95.93% <ø> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3697a9d...e3a68d3. Read the comment docs.

@ChrisAHolland
Copy link
Contributor Author

ChrisAHolland commented Apr 27, 2020

CC @kyleknap @joguSD @stealthycoin @KaibaLopez
Would I be able to get a review?

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2020

Codecov Report

Merging #5152 into develop will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5152      +/-   ##
===========================================
- Coverage    93.97%   93.95%   -0.03%     
===========================================
  Files          188      188              
  Lines        14548    14996     +448     
===========================================
+ Hits         13672    14089     +417     
- Misses         876      907      +31     
Impacted Files Coverage Δ
awscli/clidriver.py 95.93% <ø> (-0.02%) ⬇️
awscli/customizations/eks/update_kubeconfig.py 97.19% <0.00%> (-0.75%) ⬇️
awscli/customizations/s3/fileinfo.py 100.00% <0.00%> (ø)
awscli/customizations/emr/helptext.py 100.00% <0.00%> (ø)
...customizations/cloudformation/artifact_exporter.py 98.86% <0.00%> (+0.23%) ⬆️
awscli/customizations/s3/utils.py 98.61% <0.00%> (+0.50%) ⬆️
awscli/customizations/emr/createcluster.py 98.86% <0.00%> (+0.56%) ⬆️
awscli/customizations/ecs/deploy.py 60.37% <0.00%> (+1.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3697a9d...e3a68d3. Read the comment docs.

@ChrisAHolland
Copy link
Contributor Author

@kdaily Can this be merged?

@justindho justindho added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. community implementation labels May 20, 2022
@justindho justindho force-pushed the remove-redundant-parser-assignment branch from e3a68d3 to 56dcdca Compare May 20, 2022 23:17
@justindho justindho removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label May 20, 2022
@justindho justindho merged commit 1e69a50 into aws:develop May 20, 2022
@justindho justindho self-requested a review May 20, 2022 23:30
Copy link
Contributor

@justindho justindho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to click the approval button before merging, but the changes look good. Thanks @ChrisAHolland!

@justindho justindho added pending-release This issue will be fixed by an approved PR that hasn't been released yet. released and removed pending-release This issue will be fixed by an approved PR that hasn't been released yet. labels May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants