Create your own GitHub profile
Sign up for your own profile on GitHub, the best place to host code, manage projects, and build software alongside 50 million developers.
Sign up
Pinned
1,178 contributions in the last year
Activity overview
Contributed to
dotnet/roslyn,
dotnet/csharplang,
OmniSharp/omnisharp-roslyn
and 5 other
repositories
Contribution activity
July 2020
Created a pull request in dotnet/roslyn that received 11 comments
New Function Pointer Syntax
This updates function pointers to use the new syntax decided on in LDM. This is syntax-level changes only: the updated calling convention binding w…
+4,440
−1,229
•
11
comments
- Bump versions of System.Collections.Immutable and System.Reflection.Metadata to consume the new function pointer metadata changes.
- Merge master into features/function-pointers
- Support new function pointer metadata encoding
- Reduce nested testing level in x86 release E2E tests.
- Fix nullable semantic model threading issue
- Mark apis as shipped
- Skip flaky test
- Merge master into features/function-pointers
- Update optprof pipeline for 16.7
- Correct optprof pipeline for 16.7
- VB Generator Fixes
- Allow static members in interfaces to treat type parameters as invariant
- Support new function pointer metadata encoding
- Skip HighlightRefsMultipleSubmisionsVerifyRenameTags tests
- Clean up compiler logging
- Classify ??= as an operator.
- Reduce cascaded WRN_MultipleRuntimeOverrideMatches in certain rare scenarios
- [Feature] Constant Interpolated Strings- Versioning Check & Test Suite
- Add nullable annotations to NullableWalker
- Refactor VisitLambda to not create a child walker
- Log optimization data branch name during official build
- Expose BoundPattern.ConvertedType in IPatternOperation
- New Function Pointer Syntax
- Clean up Binder.GetWellKnownType API
- Unskip and adjust skip reasons for some tests.
- Add missing ArrayBuilder.Free calls
- VB Generator Fixes
- Covariant returns part 4
- Move C# editorconfig diagnostic support API to CompilationOptions, instead of SyntaxTree
- Fixing VS Crash on invalid "MemberNotNull"
- Update status for "top-level statements" feature
- Clarify expected accessibility of an EqualityContract property in a record directly inheriting from `object`.
- Update unsafe-code.md
- Fixed typo in Readme.md
- Correct LDM date
- Clarify accessibility of a synthesized record copy constructor.
- Clarify accessibility requirements for explicitly declared record copy constructor.
- Local functions and lambdas are outside init phase
- Document ability to explicitly declare Deconstruct method.
- Disallow certain modifiers in record parameters
- Applying attributes to properties and fields that are created to back primary constructor parameters
- Disallow "Clone" members
- Proposal for supporting pointer types in null coalescing operators
Created an issue in dotnet/csharplang that received 17 comments
Added: Meeting notes for July 13th, 2020
https://github.com/dotnet/csharplang/blob/master/meetings/2020/LDM-2020-07-13.md Agenda: Triage open issues
17
comments
- False positive NRT warning in `when` clause
- Update System.Runtime.Metadata reference to the RTM Version
- Simplify Function Pointer Space Formatting Rules
- TestDefaultDiagnosticProviderSemantic is flaky
- Spurious use of unassigned variable error with unimplemented partial
- Analysis of local functions/lambdas is broken for speculation
2
contributions
in private repositories
Jul 13