JoelEinbinder
Follow
Create your own GitHub profile
Sign up for your own profile on GitHub, the best place to host code, manage projects, and build software alongside 50 million developers.
Sign up
Popular repositories
-
The CSS properties supported by all three major web browser engines.
JavaScript 12
-
-
786 contributions in the last year
Contribution activity
July 2020
Created a pull request in microsoft/playwright that received 5 comments
fix(frame): check if the frame was removed before committing navigation
We got a report form a user with this stack trace:
TypeError: Cannot read property 'childFrames' of undefined at FrameManager.removeChildFramesRecu…
+3
−1
•
5
comments
- Revert "browser(firefox): fix color scheme not updating until reload"
- fix(types): don't show types that we don't export
- browser(firefox): fix color scheme not updating until reload
- test(emulation): add failing test for setting dark theme in firefox
- feat(types): export ConnectOptions
- chore(test): support typescript in jest files
- fix(test): don't leave so many zombies on sigint
- chore(test): integrate toBeGolden with jest's snapshot system
- prototype: tests without fixtures
- fix(test): don't output babel's debug info on the bots
- chore(test): restore api coverage checks
- test: screenshot on failure
- fix(test): remove defaultBrowserOptions, fix zombies on sigint
- fix(test): write after end in proxy test
- fix(chromium): reland support selectAll on macos
- chore(jest): halve the max workers
- feat(slowmo): only slowmo once per user action
- fix(chromium): select all on macos should work again
- chore(jest): defaultbrowsercontext.jest.js
- chore(jest): convert browser tests to jest
- chore(jest): convert permissions.spec.js to permissions.jest.js
- chore(jest): convert pdf.spec.js to pdf.jest.js
- All runner tests
- chore(test): add tests that use playwright-runner
- fix(accessibility): don't filter everything when the page has a title
- Some pull requests not shown.
- fix(type): unify selection behavior when typing
- test: add a test for mouse.dblclick
- test: fix api coverage
- Revert "test: screenshot on failure (#3053)"
- feat: introduce `mouse.currentState()` api
- browser(firefox): implement Page.bringToFront
- fix(chromium): reland support selectAll on macos
- test: respect CR/FF/WK/PATH env
- test: wire test commands to jest
- feat(slowmo): only slowmo once per user action
- Revert "fix(chromium): select all on macos should work again (#3006)"
- test: move fixtures to jest
- test: move remaining tests to jest
- test: move all generic page tests to jest
- chore: refactor actions part 1