Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Add support for `recursiveDenylist` option as an alternative to `recursiveBlacklist` #10236
Conversation
Yes - people do weird updates in their lockfiles all the time. I'm down with changing docs, but all existing code must work the same. If you're up for it, a separate PR which removes the old name and cleans up would be great - I can add it to the milestone of the next major release and land it at that time |
Alright - updated the code to skip this change. Now it's all in jest-validate only.
Sure you can count on me :) |
|
@wojtekmaj I forgot this over summer holidays, sorry! I wanted to merge in master so the changelog entry is in the correct place but it seems you've deleted your fork. Could you restore it? |
Summary
Part of #10235.
recursiveDenylistoption as an alternative torecursiveBlacklistinjest-validate. Does NOT removerecursiveBlacklistoption. It will continue to work, unless overwritten withrecursiveDenylist, to which I've given the priority.recursiveBlacklist(in favor of the newly added option).Changes internal calls tovalidate()to use new config (Maintainers: I'm not sure if that's a good idea - can you please advise? Should we expectjest-config, say, v26.2 work with other dependencies @ v26.1 at all times? Shall I roll that back and add it as a TODO to #10235 instead? TIA)Motivation
Part of continuous effort to get rid of non-inclusive terms like "whitelist" and "blacklist" implying that white = good and black = bad.
Test plan
jest-validatehad one suite whererecursiveBlacklistoption was used, in two cases:recursiveBlacklistoptionThe former was left intact, and copied 1:1 over to create a new test, testing whether
recursiveDenylistbeaves exactly the same asrecursiveBlacklist.The latter was updated to use
recursiveDenylist.Tests were ran successfully.