Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pinned TaskBar Log #1555

Merged
merged 1 commit into from Aug 8, 2020
Merged

Update Pinned TaskBar Log #1555

merged 1 commit into from Aug 8, 2020

Conversation

@rynz
Copy link
Contributor

@rynz rynz commented Oct 22, 2019

We've had experience from Users thinking we are collecting their computer's data because this function is logging each .lnk file not related to our application.

This pull request proposes a change to the fixPinnedExecutables logging from Info to Debug so that it is not logged to file.

@uygary
uygary approved these changes Oct 22, 2019
Copy link

@uygary uygary left a comment

This makes sense to me, and it looks good.

@anaisbetts
Copy link
Contributor

@anaisbetts anaisbetts commented Oct 22, 2019

@uygary Please don't Approve PRs for projects that you are not a maintainer of.

@uygary
Copy link

@uygary uygary commented Oct 22, 2019

@uygary Please don't Approve PRs for projects that you are not a maintainer of.

Apologies.
Since the functionality was available, I assumed it was merely considered as a form of vote.

@anaisbetts
Copy link
Contributor

@anaisbetts anaisbetts commented Oct 22, 2019

@uygary No worries - comments and 👍 s are cool, just avoid the "Approve" since it's used in many projects to gate whether a PR is merged

@anaisbetts
Copy link
Contributor

@anaisbetts anaisbetts commented Oct 27, 2019

@rynz This is probably ok, no idea who can merge these days, probably @shiftkey ?

@robmen
robmen approved these changes Aug 8, 2020
@robmen robmen merged commit 813dd91 into Squirrel:develop Aug 8, 2020
1 check passed
1 check passed
Squirrel.Squirrel.Windows Build #1.9.2-preview.7+gc03a7aed1f succeeded
Details
@rynz rynz deleted the rynz:log branch Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.