feat: remove re-routing from handler #1847
Merged
Conversation
BREAKING CHANGE: deprecates and removes re-routing when passing a string parameter to `next()`
The standard Node.js callback API accepts any value type for the first argument. Should we do the same? |
Yes, actually right now it does return an |
|
Ok, if it's consistent with the current behavior for other types I think it's reasonable. If needed we can make more changes later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
BREAKING CHANGE: deprecates and removes re-routing when passing a
stringparameter tonext()Pre-Submission Checklist
make prepushIssues
Changes
Assumes the standard node.js callback API:
cb(err, value)and treatsnext()as a callback. This way:next('foo')will be considered an error;next(null, 'foo'));