Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed docker container issue and added docker-compose file to simplify config #70

Open
wants to merge 6 commits into
base: master
from

Conversation

@orasik
Copy link

orasik commented Oct 9, 2017

  • Removed Dockerfile.
  • Added docker-compose and run.sh file.

issue

Oras Al-Kubaisi
@@ -0,0 +1,3 @@
npm install
npm install es6-promise

This comment has been minimized.

@lasley

lasley Oct 16, 2017

IMO it would be better to add this to package.json

This comment has been minimized.

@orasik

orasik Oct 17, 2017

Author

I thought of that but this would affect the application itself. I couldn't see any issue regarding using installable application (without docker) so thought it could be an issue with docker setup (like missing some libs in setup).

This comment has been minimized.

@lasley

lasley Oct 17, 2017

Adding es6-promise resolved #62 because it is a dependency of this app from what I can tell. An npm install mockbin on a blank system yields the same error as the Docker build

@joelmccracken
Copy link

joelmccracken commented Dec 19, 2017

I just downloaded this branch and built it, so far so good. I would suggest that @orasik build a new image on dockerhub so that people who go looking for it like I did find it.

@marcjay
Copy link

marcjay commented Nov 17, 2018

Are there still outstanding comments on this PR? Ran into this issue today and it would be great if this was merged

@jimmybrancaccio
Copy link

jimmybrancaccio commented Jul 7, 2020

For what it's worth I have a working image for Mockbin. I can push it to Docker Hub if anyone wants. Or you can build it yourself. The Dockerfile is:

FROM node:10.21.0-buster

WORKDIR /usr/src/mockbin

RUN git clone https://github.com/Kong/mockbin.git /usr/src/mockbin
RUN cd /usr/src/mockbin \
    && npm install \
    && npm install es6-promise
RUN npm config set mockbin:redis redis://172.18.0.103:6379

EXPOSE 8080
CMD [ "npm", "start" ]

You'll likely need to adjust the IP/name for Redis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.