Skip to content
#

re-frame

Here are 221 public repositories matching this topic...

mike-thompson-day8
mike-thompson-day8 commented Apr 6, 2020

Summary

  • The introductory re-frame documentation should be changed to better show re-frame's separation of concerns
  • Specifically, there should be 7 re-frame dominos, not 6.
  • Specifically, the existing domino #2 be split into two dominos

Notes

The following explanatory notes are written from the point of view of the current 6 domino model. These notes might serve as t

pedropombeiro
pedropombeiro commented Dec 7, 2018

Problem

Currently when a user receives a PN, we show a very generic message (no indication of sender, body, etc). This will change in the future (e.g. with status-im/status-react#7043), so it would be good to be more explicit about the fact that we are showing a generic PN message due to the db being locked. Also, since we may receive PNs from users we've since removed

danielcompton
danielcompton commented Feb 14, 2018

If the ClojureScript script file is loaded in the <head>, then it will run before the document is loaded, and you get the error message:

Uncaught TypeError: Cannot read property 'appendChild' of null
    at day8$re_frame$trace$panel_div (trace.cljs:222)
    at day8$re_frame$trace$inject_devtools_BANG_ (trace.cljs:229)
    at preload.cljs:11

I'm not sure what the best approach

danielcompton
danielcompton commented Oct 13, 2016

It's often useful to have things like status codes, headers, e.t.c. even in successful responses, e.g. when getting a 201 with a Location header. Currently we only return the body of the response. There's a few things to think about here:

  • Do we always return the full details, or is it an additional flag?
  • Do we return the raw Xhr object? They are designed to be reused and recycled, so this co
JoelSanchez
JoelSanchez commented Apr 10, 2018

Right now there are at least 2 CSS issues with the websocket web tool:

  • Responses that are too long don't overflow correctly (click on products.list and see what happens)
  • Spec documentation shows \n instead of newlines

I'm leaving this issue undone for now, as it's very beginner friendly.

Improve this page

Add a description, image, and links to the re-frame topic page so that developers can more easily learn about it.

Curate this topic

Add this topic to your repo

To associate your repository with the re-frame topic, visit your repo's landing page and select "manage topics."

Learn more

You can’t perform that action at this time.