bug: scroll assist cancels first click event #21871
Comments
|
I've found out what the issue was. I will submit a PR shortly 🙌🏽 |
|
Can confirm this |
|
Well, I thought I found the issue but actually I didn't. Hopefully, this gets fixed soon. If I can do anything, please let me know. I'm happy to help. |
|
I have been able to reproduce this sporadically as well using the (tap) event, however, in my case, switching to (click) seems to have been a passable workaround. |
|
Maybe related to #20986 |
|
Now that you mention it, this does only occur on iOS from the testing I've seen. |
|
At least you can get it to click. My ion-item button does not fire a click event at all... |
|
Actually it's been happening on Android as well. Do you have any custom Hammer.js recognizers configured? |
may help a little bit. That's what I got from release notes in 4.10.4 of Mobiscroll. |
|
Thanks to this discussion on StackOverflow I found out that two clicks/taps are only necessary when using an |
@iphilgood hi, we have tried this solution and it doesn't work for us, so if anyone has suggestions for how to fix this is would be well appreciated. |
|
Can confirm as well in this demo with these steps: |
|
I can reproduce this. The issue is with the scroll assist utility. When scroll assist starts after an input is tapped, Ionic Framework calls I can remove those lines, but I need to make sure it does not interfere with anything else. |
|
Can you try the following dev build and let me know if it resolves the issue? Angular React Vue Stencil/Vanilla JavaScript |
The dev build I posted appears to fix the repo you posted in #22740, but https://github.com/lydemann/ionic-item-scrollend-click-bug seems like a different issue. |
|
Thanks for your dev build! Awesome that this issue gets further investigated The click event gets now fired on first click but a funny thing is happening. The lower (like lower in the y axis) the item with input gets rendered, the longer it takes to fire the click event Do you have an idea why this is happening? I've updated the demo repo from my very first post with the new version and additional examples. This behaviour is actually reproducable in my demo repo. I also tested this only on iOS. Do you think I should try that on Android as well? Furthermore, if there's anything I can do to support you please let me know. |
|
@liamdebeasi - I have been working with someone on an issue related to this one and your dev build appears to fix the issue for them without causing other problems. |
|
@iphilgood Can you try this dev build? It should fix the issue you mentioned. Angular React Vue Stencil/Vanilla JavaScript |
|
@liamdebeasi Thank you so much Should I run some additional testing or can I support you in some other way? Please let me know. |
|
Glad the issue is resolved. I merged in #22845, the fix for this issue. This fix will be available in the next release of Ionic Framework. Thanks! |
|
I still have the same issue with a checkbox within a ion-item. The checkbox is not checked/unchecked on the first tap (only in iOS, in Android it works like a charm). |
|
Still having this issue sporadically on things like buttons, the ion-back-button, and other elements. It seems to happen more near the edge of the screen than other places, though I'm not sure why that would be. Possibly menu gesture interaction? |
|
Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out. |
Bug Report
Ionic version:
[ ] 4.x
[x] 5.x
Current behavior:
An
ion-itemin aion-listneeds two clicks/taps to trigger the click event. This only happens on iOS (Safari/WebKit).Expected behavior:
The event should trigger on the first click.
Steps to reproduce:
ion-listion-listcreate anion-itemwith a(click)event handlerion-itemcreate anion-labelion-itemcreate anion-inpution-itemcreate anion-buttonRelated code:
This is the markup with which you can reproduce the issue. You can also find a GIF at the bottom of this issue.
I tried to narrow it down to the following, but the issue still persists.
You can find a sample application on my GitHub.
Other information:🤔
I found out that this change of behaviour was introduced with version
v5.0.6. I've checked the changes between the versionsv5.0.5andv5.0.6but I didn't find any suspicious codeIonic info:
The text was updated successfully, but these errors were encountered: