Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemill binary docker #657
Merged
Remill binary docker #657
Conversation
IMO this is actually a better setup. I hate having to constantly update remill commit id, and now we can immediately know if a remill update broke mcsema. |
|
Someone with admin rights will have to remove the |
|
Oh, actually, I just noticed that the Anvill Docker image uses a commit file for Remill, which means it won't be the latest version of Remill. Should we get rid of the Remill commit file in the Anvill repo? |
|
Approved w/ comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ekilmer commentedMay 21, 2020
•
edited
Installs remill and anvill from docker image. This isn't as precise as the previous method since we don't use the
.remill_commit_idfile