Skip to content

Conversation

@ehmicky
Copy link
Contributor

@ehmicky ehmicky commented Aug 3, 2020

When dev.command is defined, we override the detected framework's command and args. The way this is currently done can be simplified since the branch checks that devConfig.command is defined. The assignLoudly() function assigns a default value when devConfig.command is not defined, but that can never happen in that branch, so can be removed. Furthermore, the console.log() message is printed in the wrong opposite condition.

@ehmicky ehmicky added the type: chore work needed to keep the product and development running smoothly label Aug 3, 2020
@ehmicky ehmicky requested a review from erezrokah August 3, 2020 14:06
@ehmicky ehmicky self-assigned this Aug 3, 2020
@ehmicky ehmicky merged commit e256d96 into master Aug 3, 2020
@ehmicky ehmicky deleted the chore/default-dev-command branch August 3, 2020 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: chore work needed to keep the product and development running smoothly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants