Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upchore: Convert preview to use labels #851
Conversation
|
perhaps we should add this as an additional action (not replacing the existing one). That way we can land and test without interrupting existing workflows. We'll likely have to land and iterate to make sure there are no kinks |
nschonni
force-pushed the
nschonni:preview-with-labels
branch
3 times, most recently
from
c8d0301
to
e996387
|
OK, I duplicated the job and dropped the template changes for now |
|
The event needs to be |
|
Thanks, making a note of the docs for later https://docs.github.com/en/actions/reference/events-that-trigger-workflows#pull_request_target |
|
@mmarchini I'm guessing the repo settings from https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/ will need to be enabled as well? |
|
Shouldn't be, those settings are specific for Private repositories |
| ${{ runner.os }}-node- | ||
| - name: Install Dependencies | ||
| if: steps.cache.outputs.cache-hit != 'true' && steps.comment.outputs.result == 'true' |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
nschonni
Aug 14, 2020
Author
Member
The cache key is based on the lock file, so if there are no changes to that, the ci call isn't needed. Although that's not the case for any repos that have install hooks for building.
I know this is broken for the issue version of this https://github.com/nodejs/nodejs.dev/runs/981741342?check_suite_focus=true#step:21:2 and could probably be removed
This comment has been minimized.
This comment has been minimized.
nschonni
Aug 14, 2020
Author
Member
Decided just to drop both conditions, since I don't think it's going to affect speed much. I'll see if this gives a similar error after landing
| github-token: ${{secrets.GITHUB_TOKEN}} | ||
| script: | | ||
| github.issues.createComment({ | ||
| issue_number: context.pull_request.number, |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mmarchini
Aug 14, 2020
Member
Assuming context is equal to the Action variable github.event, you can try context.number.
nschonni commentedAug 13, 2020
Description
Related Issues