Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support UpdatedDate attribute #3347

Closed
wants to merge 3 commits into from

Conversation

@weskroesbergen
Copy link
Contributor

@weskroesbergen weskroesbergen commented Jun 15, 2020

No description provided.

@msftbot
Copy link
Contributor

@msftbot msftbot bot commented Jun 15, 2020

Thanks weskroesbergen for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@vgromfeld
Copy link
Contributor

@vgromfeld vgromfeld commented Jun 18, 2020

@weskroesbergen shouldn't you also update the parsers ? It all seems to be a manual XML parsing.
You should add a description to your PR using the default template.

weskroesbergen and others added 2 commits Jun 23, 2020
@azchohfi
Copy link
Contributor

@azchohfi azchohfi commented Aug 13, 2020

@weskroesbergen did you have some time to look into this? Thanks in advance!

@michael-hawker
Copy link
Member

@michael-hawker michael-hawker commented Aug 18, 2020

Build failing due to whitespace:

  "D:\a\1\s\Windows Community Toolkit.sln" (Build target) (1) ->
       "D:\a\1\s\UnitTests\UnitTests.UWP\UnitTests.UWP.csproj" (default target) (2) ->
       "D:\a\1\s\Microsoft.Toolkit.Parsers\Microsoft.Toolkit.Parsers.csproj" (default target) (5:3) ->
       (CoreCompile target) -> 
         Rss\RssSchema.cs(64,1): error SA1028: Code should not contain trailing whitespace [D:\a\1\s\Microsoft.Toolkit.Parsers\Microsoft.Toolkit.Parsers.csproj]

I think if we go through with #3200 then all that's left in Microsoft.Toolkit.Parsers is the RSS one. I'm curious if our API can just be deprecated in favor of the .NET one here. @Sergio0694 do you know anything about this space or API?

@weskroesbergen could you provide more details on how you're using the RssParser in the toolkit and for what? Have you tried to use the .NET APIs above? Is there something wrong with them or is this API surface simpler? Any info you could provide would be really helpful.

Thanks!

@michael-hawker
Copy link
Member

@michael-hawker michael-hawker commented Aug 20, 2020

Yup, investigated that the System.ServiceModel.Syndication API is just as easy to use as our RssParser. We should remove our RssParser and tell folks to use that one instead.

            XmlReader reader = XmlReader.Create(RssFeedLocation);
            SyndicationFeed feed = SyndicationFeed.Load(reader);

            reader.Close();

            foreach (SyndicationItem element in feed.Items)
            {
                Console.WriteLine($"Title: {element.Title.Text}");
                Console.WriteLine($"Summary: {element.Summary.Text}");
            }

https://stackoverflow.com/a/14222155/8798708

I'm going to close this issue. @azchohfi can you remove the RSS Parser as part of #3435? I created Doc Issue to track migration guide.

@azchohfi
Copy link
Contributor

@azchohfi azchohfi commented Aug 20, 2020

Done.

@weskroesbergen weskroesbergen deleted the weskroesbergen:patch-2 branch Sep 2, 2020
@weskroesbergen
Copy link
Contributor Author

@weskroesbergen weskroesbergen commented Sep 2, 2020

@michael-hawker was using RSS parser to generate a feed, but don't depend on it anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.