Skip to content

/ devdocs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update terraform to version 0.12.26 #1242

Open
wants to merge 1 commit into
base: master
from
Open

Update terraform to version 0.12.26 #1242

wants to merge 1 commit into from

Conversation

@tlatsas
Copy link

@tlatsas tlatsas commented Jun 1, 2020 •
edited

Updates terraform to version 0.12.26

  • Updated the versions and releases in the scraper file
  • Ensured the license is up-to-date and that the documentation's entry in the array in about_tmpl.coffee matches it's data in self.attribution
  • Ensured the icons and the SOURCE file in public/icons/your_scraper_name/ are up-to-date if the documentation has a custom icon
  • Ensured self.links contains up-to-date urls if self.links is defined
  • Tested the changes locally to ensure:
    • The scraper still works without errors
    • The scraped documentation still looks consistent with the rest of DevDocs
    • The categorization of entries is still good
@tlatsas
Update terraform to version 0.12.26
Verified
This commit was signed with a verified signature.
tlatsas Tasos Latsas
GPG key ID: 9B11E7E5F6DAA9A3 Learn about signing commits
Loading status checks…
ddc993a
@tlatsas
Copy link
Author

@tlatsas tlatsas commented Jun 1, 2020 •
edited

Closes #1079
@simon04
Copy link
Contributor

@simon04 simon04 commented Nov 14, 2020

I'm checking a few pages and noticed that the updated docs no longer contain …

Is this intended?
@simon04
simon04 reviewed Nov 14, 2020
View changes
lib/docs/scrapers/terraform.rb
@@ -12,7 +12,7 @@ class Terraform < UrlScraper

html_filters.push 'terraform/entries', 'terraform/clean_html'

options[:skip_patterns] = [/enterprise/, /enterprise-legacy/]
options[:skip_patterns] = [/enterprise/, /enterprise-legacy/, /guides/]

options[:attribution] = <<-HTML
&copy; 2018 HashiCorp</br>

This comment has been minimized.

Sign in to view
@simon04

simon04 Nov 14, 2020
Contributor

The attribution string is outdated.
@tlatsas
Copy link
Author

@tlatsas tlatsas commented Nov 16, 2020 •
edited

Hi @simon04! I believe at some point between the time I opened this PR and now, the documentation pages have gone through a redesign so I should probably rework this a bit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon04 simon04

Assignees

@tlatsas tlatsas

Labels
docs/update issue/needs-info
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@tlatsas @simon04
You can’t perform that action at this time.