Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdding a note about webpack & ESM #228
Open
Labels
Comments
|
Thank you @ahmedelgabri, sounds good! |
|
@shuding , is this an active issue? If yes, could you please provide more context? |
|
@tanmaylaud The issue of broken code for old browsers is already resolved in latest releases. So we are only missing documentation (or a notice message) here. |
|
@shuding So a note in the parent README that mentions support for older browsers (given in the issue above) would be good enough? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A bit of context, we introduced
swrtwo weeks ago to our codebase. Everything is working fine, but we started to get some reports about some parts of the app being broken in slightly older browsers (Chrome 49, Firefox 59, Edge 18, etc…)We found out that
swrwas causing a syntax error in these browsers because webpack by default picked the ESM build (rightly so) but because it's not transpiled it ended in the bundle without going through our babel config. Which broke these older browsers. So I'd like to add a not in README file, about the ESM build & webpack, what do you think?