Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple (non-implicit) parameters to a symbolic/infix should be avoided #10221

Open
renatocaval opened this issue Apr 24, 2020 · 3 comments · May be fixed by #10229
Open

Multiple (non-implicit) parameters to a symbolic/infix should be avoided #10221

renatocaval opened this issue Apr 24, 2020 · 3 comments · May be fixed by #10229

Comments

@renatocaval
Copy link
Member

@renatocaval renatocaval commented Apr 24, 2020

In #10199 we added symbolic methods to TypeMap, but as signaled by @NthPortal we should avoid this.

Triggered by:

I'm a bit late to the party here, but multiple (non-implicit) parameters to a symbolic/infix method are highly discouraged, and planned to be deprecated. See scala/scala-dev#496 and lampepfl/dotty#4311 (comment).

Originally posted by @NthPortal in #10199

@renatocaval
Copy link
Member Author

@renatocaval renatocaval commented Apr 24, 2020

From my part we can remove all the new symbolic operators.

@renatocaval renatocaval added this to the Play 2.x milestone Apr 24, 2020
@mkurz
Copy link
Member

@mkurz mkurz commented Apr 24, 2020

... we added symbolic methods ... but ... we should avoid this

Just to make things clear, not symbolic methods should be avoided, but multi-params for this methods.

@renatocaval
Copy link
Member Author

@renatocaval renatocaval commented Apr 25, 2020

Yes, but we will have an imbalance in the API if we remove only a those with multi-params.

@mkurz mkurz linked a pull request that will close this issue Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.