Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blessed level UI #166

Open
wants to merge 31 commits into
base: master
from
Open

Blessed level UI #166

wants to merge 31 commits into from

Conversation

@jeroenrinzema
Copy link

@jeroenrinzema jeroenrinzema commented May 27, 2018

New level UI build with Blessed. See #155 for more info. This PR is still a work in progress. The following tasks still need to be completed.

  • Write tests
  • Write documentation
  • Clean up and refactor code
  • Fix TODOs
@codecov-io
Copy link

@codecov-io codecov-io commented May 27, 2018

Codecov Report

Merging #166 into master will decrease coverage by 20.8%.
The diff coverage is 0.69%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #166       +/-   ##
===========================================
- Coverage   92.64%   71.84%   -20.81%     
===========================================
  Files          92       91        -1     
  Lines        1088     1250      +162     
  Branches      165      212       +47     
===========================================
- Hits         1008      898      -110     
- Misses         65      304      +239     
- Partials       15       48       +33
Impacted Files Coverage Δ
...warriorjs-cli/src/level/components/getUnitStyle.js 100% <ø> (ø)
...s/warriorjs-cli/src/level/components/totalScore.js 0% <0%> (ø)
...ages/warriorjs-cli/src/level/components/failure.js 0% <0%> (ø)
...es/warriorjs-cli/src/level/preform/confirmation.js 0% <0%> (ø)
.../warriorjs-cli/src/level/components/towerReport.js 0% <0%> (ø)
.../warriorjs-cli/src/level/components/levelHeader.js 0% <0%> (ø)
...ages/warriorjs-cli/src/level/components/success.js 0% <0%> (ø)
...s/warriorjs-cli/src/level/components/logMessage.js 0% <0%> (ø)
packages/warriorjs-cli/src/level/layout/base.js 0% <0%> (ø)
...arriorjs-cli/src/level/components/warriorStatus.js 0% <0%> (ø)
... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04249d0...217c98b. Read the comment docs.

Jeroen Rinzema and others added 10 commits May 28, 2018
Jeroen Rinzema
Jeroen Rinzema
Jeroen Rinzema
@jeroenrinzema
Copy link
Author

@jeroenrinzema jeroenrinzema commented May 28, 2018

Currently WarriorJS uses 2 different approaches to generating the interfaces. Is it an idea to use Blessed for all interfaces?

Jeroen Rinzema added 2 commits May 28, 2018
@olistic
Copy link
Owner

@olistic olistic commented May 28, 2018

@jeroenrinzema I haven't looked at the code yet, but I saw you used npm to install blessed. You should use lerna because of how the project is set up (multi-package repo using yarn workspaces). The command you need is: lerna add blessed --scope=@warriorjs/cli.

@olistic
Copy link
Owner

@olistic olistic commented May 28, 2018

@jeroenrinzema

Currently WarriorJS uses 2 different approaches to generating the interfaces. Is it an idea to use Blessed for all interfaces?

If you mean the dialogs using Inquirer.js on one side and the printPlay() function (and all functions derived from that one) on the other, the answer is no. The scope of this PR should be limited to replace only the latter (printPlay()). All Inquirer.js dialogs should be left as they are.

Jeroen Rinzema added 2 commits May 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.