Skip to content

/ DRAW

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CommentForest.length does not include entries expanded from MoreComments #61

Open
bkonyi opened this issue Apr 18, 2018 · 3 comments
Open

CommentForest.length does not include entries expanded from MoreComments #61

bkonyi opened this issue Apr 18, 2018 · 3 comments
Labels
bug-fix good first issue testing

Comments

@bkonyi
Copy link
Member

@bkonyi bkonyi commented Apr 18, 2018

This needs to be fixed and additional tests need to be written for comment related functionality.
@Bricktheworld
Copy link

@Bricktheworld Bricktheworld commented Apr 5, 2020

Any update on this?
@Bricktheworld
Copy link

@Bricktheworld Bricktheworld commented Apr 5, 2020 •
edited

This actually really needs to have some fix to it, because as it stands, I have a list view however when I set the number of items, I always receive an error with there being a more comments option. I would at the very least like an option to detect if there are any "more comments" as a way to ensure that I can get 1 minus the length of the comment forest. Any way I can achieve this?
@Bricktheworld
Copy link

@Bricktheworld Bricktheworld commented Apr 6, 2020

Ok, have found a solution. Simply check if an element is MoreComment with "if (someCommentForest[index] is MoreComment) "...

I wonder if that would be easy to check in the actual ".length" property in the CommentForest, might make a pull request for that
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug-fix good first issue testing
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@bkonyi @Bricktheworld
You can’t perform that action at this time.