Skip to content

/ sql.js

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue where getColumnNames() returned an empty array if SELECT … #412

Merged
merged 3 commits into from Aug 10, 2020
Merged

Fixed issue where getColumnNames() returned an empty array if SELECT … #412

merged 3 commits into from Aug 10, 2020

Conversation

@cpainterwakefield
Copy link
Contributor

@cpainterwakefield cpainterwakefield commented Aug 10, 2020

…query returned 0 rows.
@cpainterwakefield
Fixed issue where getColumnNames() returned an empty array if SELECT …
Loading status checks…
2e307e1 
…query returned 0 rows.
@cpainterwakefield
Fixed line length issue with last commit.
Loading status checks…
e4b815b
@cpainterwakefield
More eslint fixes
Loading status checks…
6ff7383
@lovasoa
Copy link
Member

@lovasoa lovasoa commented Aug 10, 2020

See #388
@cpainterwakefield
Copy link
Contributor Author

@cpainterwakefield cpainterwakefield commented Aug 10, 2020

I did look at #388 - it looked like that one got rejected because it broke tests by changing the way exec() worked in returning result sets. My change only effects the getColumnNames() method of Statement, and all the tests run green.
@lovasoa
lovasoa approved these changes Aug 10, 2020
View changes
@lovasoa
Copy link
Member

@lovasoa lovasoa commented Aug 10, 2020

OK, sorry, this patch looks good to me. Thank you !
@lovasoa lovasoa merged commit 20157a1 into sql-js:master Aug 10, 2020
1 check passed
1 check passed
build
Details
@lovasoa lovasoa mentioned this pull request Oct 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovasoa lovasoa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@cpainterwakefield @lovasoa