Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplemented ICE restart [Demonstration Only For Feedback] #715
Conversation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
momakes commentedJul 26, 2020
Hey! I implemented ICE restarts in my fork based on #579 and it works (only missing the if for disabling restart when trickle is
false)Note: This is draft because it includes a @feross's PR too, but I wanted to get your feedback and if you're happy with it overall, I will create a clean PR with just the ICE restarts👍