This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Updated chromedriver path to ensure correct symlink creation#19175
Merged
zoracon merged 1 commit intoEFForg:masterfrom Apr 29, 2020
Merged
Updated chromedriver path to ensure correct symlink creation#19175zoracon merged 1 commit intoEFForg:masterfrom
zoracon merged 1 commit intoEFForg:masterfrom
Conversation
The latest versions of the chromium-browser package now install by default to /usr/lib/chromium-browser, not /usr/lib/chromium. By updating the locations where /usr/lib/chromium is used to the new path, the symlink for the chromedriver is properly created.
Contributor
Author
|
Hello there. Just checking in real quick - I saw that this pull request was closed, but then reopened. What's the status on this commit? If you have any questions, feel free to let me know. Thanks! |
Contributor
|
@ShenZhouHong It was closed and reopened in order to rerun tests. Don't worry about that. |
zoracon
approved these changes
Apr 29, 2020
Contributor
zoracon
left a comment
zoracon
left a comment
There was a problem hiding this comment.
Was able to reproduce issue and pull PR and test, merging in! Thank you for your patience!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest versions of the chromium-browser package now install by
default to /usr/lib/chromium-browser, not /usr/lib/chromium. By
updating the locations where /usr/lib/chromium is used to the new
path, the symlink for the chromedriver is properly created.
Further details can be found in issue #19174
List related issues if any