Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix Mods being able to edit Admins, Split permissions #2113
Conversation
|
For some reason I cannot add comments to the Serializer.
The last Why exactly are there no new policy methods, are these magically applied? Would you have kept the |
|
Thanks for the feedback @luceos I'll work on implementing your suggestions, I think the problem stems from my lack of experience working with Flarums permission systems and not know exactly how policies got applied. With your insight I think I can do this way better. |
|
In theory this could work without a policy: if no policy governs a permission, there'll be a check as to whether the user belongs to a group that has that permission. However, I agree that a policy could be useful here, as that'd be a better place to put the |
|
I agree with the existing comments. Please ping me again and I'll do an actual review when more code is pushed. |
7c943eb
to
674417c
|
@clarkwinkelmann I've refactored it almost completely |
|
Because we now auto-format our JS code with Prettier, this branch now has conflicts with Please take the steps outlined in the forum to resolve the conflicts. |
e01422e
to
a543389
|
Rebase was completed |
|
I'd like to discuss the naming convention for the |
|
@franzliedke when you get back from vacation, what's the verdict on permission naming? |
|
I think Clark brings up a good point here: #2113 (comment), a warning message would be nice. Other than that, the only thing left is Franz's decision on the ability naming. |
tankerkiller125 commentedApr 2, 2020
•
edited
**Fixes #1965 **
Changes proposed in this pull request:
Reviewers should focus on:
Screenshot
Confirmed
composer test).Required changes: