Skip to content
#

mozilla

Here are 414 public repositories matching this topic...

fenix
cadeyrn
cadeyrn commented Aug 22, 2020

Steps to reproduce

  1. change you language to German (or another language with a longer "try again" string, it's not reprodudible with English)
  2. try to download something (it will always fail in the current build, so every file will work as an example)

Expected behavior

padding on the left and the right of the button.

Actual behavior

no padding.

![Screenshot_2020082

oliviabrown9
oliviabrown9 commented Jan 15, 2019

SearchSuggestionsPromptView is not always displayed during tests as seen in screenshots, which causes both the enable and disable tests to fail.

Test Failure

t =    42.16s Assertion Failure: SearchSuggestionsTest.swift:89: Failed to find "SearchSuggestionsPromptView" Other after 30 seconds.
t =    42.19s Assertion Failure: BaseTestCase.swift:53: Asynchronous wait failed: Exceeded ti
wolfbeast
wolfbeast commented Mar 8, 2020

_getPref functions in the application code cater to being able to supply a default.
Since we already have this functionality in your preferences module, this is no longer needed and these custom functions need to go.
Additionally, the _getPref function determines its return type dynamically based on the pref to get. This makes the call ambiguous and can lead to bugs by having a wrong type re

wolfbeast
wolfbeast commented Jun 18, 2018

We're having a mix of named function syntax (old style) and non-named function syntax (new style) in our internal JavaScript.

The old style was mostly there for JS stack traces before they were as nice as what we have now. Since that's solved, having named functions has become unnecessary and will just take up JS data space when processing.

We should convert all named function syntax in JSO

Ishaan28malik
Ishaan28malik commented Oct 21, 2019

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

**Desktop (please comp

Improve this page

Add a description, image, and links to the mozilla topic page so that developers can more easily learn about it.

Curate this topic

Add this topic to your repo

To associate your repository with the mozilla topic, visit your repo's landing page and select "manage topics."

Learn more

You can’t perform that action at this time.