Problem:

As mentioned in the comment New cipher suites MUST be added here, IN ORDER, or they will not be properly initialized.

https://github.com/awslabs/s2n/blob/64297d8ce45a38394094f1c31b2ecf5735472edb/tls/s2n_cipher_suites.c#L768-L772

Solution:

Unit test to validate the array order.

• **Does

tests/include/test/psa_crypto_helpers.h contains function definitions. That's a remnant from when we didn't have tests/src/*.c and unit tests had to be compiled as a monolithic C file. It's a problem because merely including the header causes an unused-function warning. The header should contain only function declarations (or static inline function definitions, but the functions in that head

https://scotthelme.co.uk/a-new-security-header-feature-policy/

I guess it will be easy to add, because we certainly don't use any of these features.
Or maybe "gyroscope" or so may be used by the random number generator in sjcl, but that's all.

socket.cpp, socket_udp.cpp and cli/socket_utils.h have a lot of shared/duplicated code for handling differences in socket interface between BSD and Windsock. Consolidate into a single internal header which can be used across all three.