Skip to content

/ leon

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time module #30

Open
ctombumila37 opened this issue Feb 19, 2019 · 11 comments
Open

Time module #30

ctombumila37 opened this issue Feb 19, 2019 · 11 comments
Labels
feature request good first issue package/module

Comments

@ctombumila37
Copy link
Contributor

@ctombumila37 ctombumila37 commented Feb 19, 2019

Feature Use Case

Leon, what time is it?
- It's quarter past ten.

Feature Proposal

Implement a new module / package.
@louistiti
Copy link
Member

@louistiti louistiti commented Feb 20, 2019

✨ Time Package - What Time Module
@louistiti
Copy link
Member

@louistiti louistiti commented Feb 20, 2019

Hello @ctombumila37,

Thanks for this feature request.

This is definitely a module that can be done with the current version (1.0.0-beta.0).

Is that something you would like to work on?
@hk1997
Copy link

@hk1997 hk1997 commented Feb 20, 2019

Can I work on this feature?
@louistiti
Copy link
Member

@louistiti louistiti commented Feb 20, 2019

Hello @hk1997,

Yes with pleasure. Let's wait a moment to see if @ctombumila37 did not start anything first.
@ctombumila37
Copy link
Contributor Author

@ctombumila37 ctombumila37 commented Feb 25, 2019

Sorry for the delayed response.

@hk1997 Feel free to go ahead :)
@hk1997
Copy link

@hk1997 hk1997 commented Feb 26, 2019

sure, I am starting it then. thanks
@louistiti
Copy link
Member

@louistiti louistiti commented Feb 26, 2019

Awesome! Please reference this issue to the PR 👍
@louistiti
Copy link
Member

@louistiti louistiti commented Mar 9, 2019 •
edited

A PR has been created for that #53.
@rohithjayaraman
Copy link

@rohithjayaraman rohithjayaraman commented Oct 11, 2019

Is this done or still open ?
@louistiti
Copy link
Member

@louistiti louistiti commented Oct 11, 2019

@theparselmouth it is done based on an old codebase, so you can adapt it to the latest Leon version if you want and try to improve it.
@sagamji100
Copy link

@sagamji100 sagamji100 commented Jun 29, 2020 •
edited

Interesting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request good first issue package/module
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
@louistiti @hk1997 @ctombumila37 @rohithjayaraman @sagamji100
You can’t perform that action at this time.