Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix toaster types #920
Open
Fix toaster types #920
Conversation
This resolves the type error when passing react component to toast
|
@AntsiferovMaxim Thanks for this PR! Left a comment inline - let me know if you have any questions! |
| @@ -2312,19 +2312,19 @@ export const toaster: { | |||
| /** | |||
| * Opens a Toast with an intent of none. | |||
| */ | |||
| notify: (title: string, settings?: ToasterSettings) => void | |||
| notify: (title: string | React.ReactNode, settings?: ToasterSettings) => void | |||
This comment has been minimized.
This comment has been minimized.
akleiner2
Aug 28, 2020
Contributor
We can simplify these title types to just be React.ReactNode - React.ReactNode is a catch-all type that encompasses string as a part of it.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
AntsiferovMaxim commentedAug 3, 2020
This resolves the type error when passing react component to toast