Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Normalize the licensing scheme #737
Conversation
| @@ -0,0 +1,4 @@ | |||
| Envoy | |||
| Copyright (c) 2017 Lyft Inc. All rights reserved. | |||
mattklein123
Apr 11, 2017
Member
2016-2017?
2016-2017?
| Envoy | ||
| Copyright (c) 2017 Lyft Inc. All rights reserved. | ||
|
|
||
| Licensed under Apache License 2.0. See LICENSE.txt for terms. |
mattklein123
Apr 11, 2017
Member
s/LICENSE.txt/LICENSE
s/LICENSE.txt/LICENSE
|
@ryan-lane can you take a look at this? |
|
|
||
| Licensed under Apache License 2.0. See LICENSE for terms. | ||
|
|
||
| Zipkin (Apache V2) |
PiotrSikora
Apr 12, 2017
Member
None of the libraries listed here are part of this repository, so this doesn't belong here.
None of the libraries listed here are part of this repository, so this doesn't belong here.
timperrett
Apr 12, 2017
Author
Contributor
Yeah you're probably right, given those items are not included in the source itself. Might be worth have a note about other software that's included, for explicitness - it could just go in the README or something.
Yeah you're probably right, given those items are not included in the source itself. Might be worth have a note about other software that's included, for explicitness - it could just go in the README or something.
| @@ -1,15 +1,202 @@ | |||
| Envoy | |||
| Apache License | |||
| same "printed page" as the copyright notice for easier | ||
| identification within third-party archives. | ||
|
|
||
| Copyright [yyyy] [name of copyright owner]. |
PiotrSikora
Apr 12, 2017
Member
This should be filled out, i.e.
Copyright 2016-2017, Lyft Inc.
and then you could drop NOTICE file, which isn't really used outside of Apache's own projects.
This should be filled out, i.e.
Copyright 2016-2017, Lyft Inc.
and then you could drop NOTICE file, which isn't really used outside of Apache's own projects.
timperrett
Apr 19, 2017
Author
Contributor
@PiotrSikora actually no, I dont think this is accurate. The license needs to be the license verbatim, not with adjustments. Given this is Lyft's project, defer to @ryan-lane for call on it. Our legal beavers have us include it verbatim and use the notice file, as directed by apache licensing.
@PiotrSikora actually no, I dont think this is accurate. The license needs to be the license verbatim, not with adjustments. Given this is Lyft's project, defer to @ryan-lane for call on it. Our legal beavers have us include it verbatim and use the notice file, as directed by apache licensing.
PiotrSikora
Apr 19, 2017
Member
You're right. I always thought you had to include it verbatim, like you said, but when I was double checking it with Apache projects last week, I thought they had changed it... Of course, now I cannot find this, so please ignore my previous comment.
You're right. I always thought you had to include it verbatim, like you said, but when I was double checking it with Apache projects last week, I thought they had changed it... Of course, now I cannot find this, so please ignore my previous comment.
|
Also, while we're on the topic, in theory all files should contain the copyright notice, i.e. in their headers. |
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
|
|
PiotrSikora
Apr 12, 2017
Member
Nit: remove empty last line.
Nit: remove empty last line.
|
@PiotrSikora yeah re: file headers. Sigh. I will open a GH issue to automate this somehow. We need a script that will add the headers and also add checking to check_format that the header exists. |
| @@ -0,0 +1,4 @@ | |||
| Envoy | |||
| Copyright (c) 2016-2017 Lyft Inc. All rights reserved. | |||
ryan-lane
Apr 12, 2017
I'm not sure this should have All rights reserved.
I'm not sure this should have All rights reserved.
ryan-lane
Apr 12, 2017
See the example notice file: https://www.apache.org/licenses/example-NOTICE.txt
See the example notice file: https://www.apache.org/licenses/example-NOTICE.txt
|
@timperrett we are OK to merge this pending the small nits above. Can you fix? If not LMK and I can close and open a new PR. |
|
And right, headers will be required but that would need automating as you've pointed out @mattklein123 :-) Hope this helps. |
|
Thanks @timperrett for your legal acumen |
mattklein123
merged commit e21043d
into
envoyproxy:master
| Envoy | ||
| Copyright 2016-2017 Lyft Inc. | ||
|
|
||
| Licensed under Apache License 2.0. See LICENSE for terms. |
PiotrSikora
Apr 19, 2017
Member
Is the last line really needed?
Is the last line really needed?
Automatic merge from submit-queue. [DO NOT MERGE] Auto PR to update dependencies of proxy This PR will be merged automatically once checks are successful. ```release-note none ```
Typically speaking, if you have work you depend on, or other inspiration you took and made a derivative work then those licenses should be included in the NOTICE file... However, the biggest problem with all OSS is that not much has been tested in court. As it stands Envoy does not include a proper license, so doing so seems prudent in the least (notice how Github was unable to parse the license for auto license detection).
DISCLAIMER: I'm not a lawyer :-)