Code block display in details tag#1790
Closed
james-geiger wants to merge 1 commit intoBookStackApp:masterfrom
Closed
Code block display in details tag#1790james-geiger wants to merge 1 commit intoBookStackApp:masterfrom
james-geiger wants to merge 1 commit intoBookStackApp:masterfrom
Conversation
Member
|
Thanks for offering this @james-geiger and sorry for my really late response. To be honest I'd like to avoid polling unless it's really necessary, just because polling UI elements can build up and slow the UI quite quickly or have unintended effects. Looks like a details element fires a |
Member
|
This has now been addressed in 5404f22 so will therefore close this. Thanks @james-geiger for your original PR here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #781. Use codemirror display/autoReload addon to watch for state changes and resize the codemirror blocks if they were hidden when the DOM was loaded.
I've set this to poll every 50ms, which was a bit smoother transition. A 1ms poll, just for fun, produced the best result but is likely to cause performance issues.