Skip to content
#

contribution

Here are 180 public repositories matching this topic...

open-sauced
dejongnj
dejongnj commented Oct 21, 2019

When checking for duplicated IDs we push existing ids into an array: https://github.com/indeedeng/starfish/blob/dc651c846bbbe1bc6eefee70a24cdf44383c59a2/index.js#L35

Changing the data structure to an object will allow for O(1) lookup time instead of O(n) having to look through the whole array to check which will speed up the process and scale a little better. It could also reduce/simply the log

Improve this page

Add a description, image, and links to the contribution topic page so that developers can more easily learn about it.

Curate this topic

Add this topic to your repo

To associate your repository with the contribution topic, visit your repo's landing page and select "manage topics."

Learn more

You can’t perform that action at this time.