Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace #3

Open
wants to merge 3 commits into
base: master_ci
from

Commits on Mar 26, 2020

  1. Allow REINDEX to change tablespace

    REINDEX already does full relation rewrite, this patch adds a
    possibility to specify a new tablespace where new relfilenode
    will be created.
    ololobus committed Mar 26, 2020
  2. Specially handle toast relations during REINDEX.

    Is this fine ?  It says "cannot reindex system catalogs concurrently" (once),
    and hits the pg_toast tables for information_schema.  Should it skip toast
    indexes (like it said) ?  Or should it REINDEX them on the same tablespace?
    
    template1=# REINDEX DATABASE CONCURRENTLY template1 TABLESPACE pg_default;
    2020-03-09 15:33:51.792 CDT [6464] WARNING:  cannot reindex system catalogs concurrently, skipping all
    WARNING:  cannot reindex system catalogs concurrently, skipping all
    2020-03-09 15:33:51.794 CDT [6464] WARNING:  skipping tablespace change of "pg_toast_12558_index"
    2020-03-09 15:33:51.794 CDT [6464] DETAIL:  Cannot move system relation, only REINDEX CONCURRENTLY is performed.
    WARNING:  skipping tablespace change of "pg_toast_12558_index"
    DETAIL:  Cannot move system relation, only REINDEX CONCURRENTLY is performed.
    2020-03-09 15:33:51.924 CDT [6464] WARNING:  skipping tablespace change of "pg_toast_12543_index"
    2020-03-09 15:33:51.924 CDT [6464] DETAIL:  Cannot move system relation, only REINDEX CONCURRENTLY is performed.
    WARNING:  skipping tablespace change of "pg_toast_12543_index"
    DETAIL:  Cannot move system relation, only REINDEX CONCURRENTLY is performed.
    2020-03-09 15:33:51.982 CDT [6464] WARNING:  skipping tablespace change of "pg_toast_12548_index"
    2020-03-09 15:33:51.982 CDT [6464] DETAIL:  Cannot move system relation, only REINDEX CONCURRENTLY is performed.
    WARNING:  skipping tablespace change of "pg_toast_12548_index"
    DETAIL:  Cannot move system relation, only REINDEX CONCURRENTLY is performed.
    2020-03-09 15:33:52.048 CDT [6464] WARNING:  skipping tablespace change of "pg_toast_12553_index"
    2020-03-09 15:33:52.048 CDT [6464] DETAIL:  Cannot move system relation, only REINDEX CONCURRENTLY is performed.
    WARNING:  skipping tablespace change of "pg_toast_12553_index"
    DETAIL:  Cannot move system relation, only REINDEX CONCURRENTLY is performed.
    REINDEX
    Justin Pryzby authored and ololobus committed Mar 26, 2020
  3. Allow CLUSTER and VACUUM FULL to change tablespace

    ololobus committed Mar 26, 2020
You can’t perform that action at this time.