Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Replace --auto-accept with --interactive #3743
Draft
Conversation
Auto-accept erroneously assumed acceptance where the install generator actively asks for content in several places.
Squiggle heredocs were introduced in Ruby 2.3, so we can finally use them at large.
It wasn't doing a thing.
Add a description and default value, that is overridden when solidus_auth_devise will be the auth extension.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Description
The current solidus install generator will ask for a number of things unless
--auto-acceptis provided. Since many of the things asked are not simple yes/no questions, and by default Rails doesn't require any interaction when generating a new app, we should move to an opt-in--interactiveflag.The current PR only switches to the new CLI option and cleans up the generator to make it more maintainable by solidus core and usable by end-users.
Checklist: