Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks to improve usage of copied Fudge #73

Open
jayvdb opened this issue Jun 27, 2019 · 1 comment
Open

Tweaks to improve usage of copied Fudge #73

jayvdb opened this issue Jun 27, 2019 · 1 comment

Comments

@jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Jun 27, 2019

I am copying Fudge into our mobans repository - it is only two files, and this means we can pin our version to a development version - and it is distributed from there to all of the coala repositories.

Three tweaks that would help.

  1. Remove trailing whitespace : #72 While I am excluding the Fudge files from most of our linter rules, the one rule which I dont like to exclude files from is the 'no trailing whitespace' rule. Trailing whitespace causes git rebase to emit confusing messages, even when the rebase is not touching the files which have trailing whitespace.
  2. Allowing FudgeTools.psm1 to reside in the same directory as Fudge.ps1 , removing the need for a Modules subdirectory containing only a single file.
  3. The version Fudge reports is Fudge v$version$, likely because it couldnt find the correct version to report. The quick fix is to not report a version when there is no real version for the code being executed.
@Badgerati
Copy link
Owner

@Badgerati Badgerati commented Jun 27, 2019

  1. I can do as apart of #61
  2. The $version$ is a placeholder that gets stamped in during release packaging. To be honest I've been thinking about removing the version messages, and have a -version parameter for Fudge (with the version hard-coded, and updated just prior to a release).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.