Skip to content

/ nuxt.js

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vue-app): added nuxt-loading events #7930

Open
wants to merge 1 commit into
base: dev
from
Open

feat(vue-app): added nuxt-loading events #7930

wants to merge 1 commit into from
+99 −1

Conversation

@rotem-bar
Copy link

rotem-bar commented Aug 16, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Resolves #7893, added the following events to nuxt-loading:

  • progress (on percentage change)
  • started
  • paused
  • resumed
  • failed
  • finished

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.
@rotem-bar
feat(vue-app): added nuxt-loading events
Loading status checks…
82a4a4b
@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2020

Codecov Report

Merging #7930 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #7930   +/-   ##
=======================================
  Coverage   68.92%   68.92%           
=======================================
  Files          91       91           
  Lines        3846     3846           
  Branches     1041     1041           
=======================================
  Hits         2651     2651           
  Misses        971      971           
  Partials      224      224
Flag Coverage Δ
#unittests 68.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37c903f...82a4a4b. Read the comment docs.
@pi0 pi0 added the pending label Sep 2, 2020
@pi0
Copy link
Member

pi0 commented Sep 2, 2020

Hi @rotem-bar and thanks for PR ❤️ We have to keep it pending for next semver/minor release which is after nuxt3 api was more stable. Meanwhile you can override it by creating app/components/nuxt-loading.vue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pending
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Add event hooks to nuxt-loading component
3 participants
@rotem-bar @codecov-commenter @pi0
You can’t perform that action at this time.