Skip to content

/ v86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically build libv86 on CI #297

Closed
filips123 opened this issue Sep 8, 2019 · 5 comments
Closed

Automatically build libv86 on CI #297

filips123 opened this issue Sep 8, 2019 · 5 comments
Labels
enhancement good first issue

Comments

@filips123
Copy link
Contributor

@filips123 filips123 commented Sep 8, 2019 •
edited

Can you automatically build libv86.js on Travis CI at every commit and publish it to some server or GitHub Pages? This would be very good because users then won't need to install and configure Closure Compiler and other build dependencies.

Can you also configure Makefile to also build sourcemap file for libv86.js?

Also, the version on your website is very old (from 2018). Can you also update it?
@pitust
Copy link

@pitust pitust commented Sep 10, 2019

Actually, here is what I do when I want to use v86:

wsl wget http://copy.sh/v86/build/libv86.js
@pitust
Copy link

@pitust pitust commented Sep 10, 2019

but I didn't know on the website it's old
@pitust
Copy link

@pitust pitust commented Sep 10, 2019

I also noticed maybe cat instead of closure compiler (for debug builds)? This would be faster.
@filips123
Copy link
Contributor Author

@filips123 filips123 commented Jan 8, 2020

@copy I'm currently working on PR to build libv86 in Travis CI and publish it to GitHub Pages. Should I publish ACPI version, non-ACPI version of both?
@filips123 filips123 mentioned this issue Jan 8, 2020
Closed
@copy
Copy link
Owner

@copy copy commented Sep 30, 2020

I also noticed maybe cat instead of closure compiler (for debug builds)? This would be faster.

Closure Compiler also does some type checking and linting, I don't think we should disable that.

Closing this issue as it's complete.
@copy copy closed this Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Build libv86 with GitHub Actions
3 participants
@copy @filips123 @pitust
You can’t perform that action at this time.