Skip to content

/ requests-html

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyppeteer as optional dependency #182

Open
jonashaag opened this issue May 17, 2018 · 2 comments
Open

pyppeteer as optional dependency #182

jonashaag opened this issue May 17, 2018 · 2 comments
Labels
enhancement good first issue
Milestone
v0.11.0

Comments

@jonashaag
Copy link

@jonashaag jonashaag commented May 17, 2018

pyppeteer is a required dependency, but fails to build on PyPy3. How about making it an optional dependency?
@tribeclickgh
Copy link

@tribeclickgh tribeclickgh commented May 17, 2018

+1 to this.

I find it confusing how this project is already in 0.9 (after 3 months from its inception) when pyppeteer (on which this project relies) is only at version 0.0.16, and "Currently not all features are tested and some APIs are unstable"
@oldani
Copy link
Member

@oldani oldani commented Feb 26, 2019

Agree with you guys, Is anyone willing to implement this?
@oldani oldani added this to the v0.11.0 milestone Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
v0.11.0
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@jonashaag @oldani @tribeclickgh
You can’t perform that action at this time.