Array.prototype.toLocaleString uses comma space separator instead of just comma #6361

sunlili · 2019-12-22T04:57:11Z

I run following code in ch 1.11.15, the result of ChakraCore is different from other js engines. Though in specification, “string-concatenation” is not defined clearly, other engines’ output is same.

Code:

let arg_0 = ['Fire', '', 'Wind', 'Rain'];
arr2 = arg_0.toLocaleString();

print(JSON.stringify(arr2))

output of ch:
"Fire, , Wind, Rain"

output of other engines:
"Fire,,Wind,Rain"

ISec Lab
2019.12.21

rhuanjl · 2020-03-25T23:01:20Z

Per spec this is implementation defined, but:
a) all other engines just use a comma instead of comma & space AND
b) in toString (instead of toLocaleString) we use comma only

Should change be consistent - very easy fix change to use GetCommaDisplayString instead of GetCommaSpaceDisplayString here:

ChakraCore/lib/Runtime/Library/JavascriptArray.cpp

Line 8393 in c459fea

separator = scriptContext->GetLibrary()->GetCommaSpaceDisplayString();

Updating tests that use this may take a little while though - tagging as good first issue.

muhdmud · 2020-07-28T08:57:09Z

Hi, could i work on this?

ppenzin · 2020-08-21T05:32:53Z

@muhdmud, sorry for the late reply - surely you can, let me know if you need any guidance on this.

muhdmud · 2020-08-24T02:18:12Z

@ppenzin yes thank you for the opportunity! I will have a go at it this week

muhdmud · 2020-08-30T10:14:12Z

@ppenzin Can I just submit a WIP pr with that oneliner change, then subsequently work on the tests? I assume the tests that i am suppose to be looking at is at chakracore/test/string concats, please correct me if im wrong

ppenzin · 2020-09-03T01:12:32Z

@muhdmud Sorry for late reply. Yes, that would be great!

rhuanjl added Compatibility good first issue help wanted labels Mar 25, 2020

rhuanjl changed the title ~~Different Realization of "string-concatenation" from other engines~~ Array.prototype.toLocaleString uses comma space separator instead of just comma Mar 25, 2020

muhdmud mentioned this issue Sep 8, 2020

fixing issue 6361 #6499

Open

microsoft / ChakraCore

Array.prototype.toLocaleString uses comma space separator instead of just comma #6361

Array.prototype.toLocaleString uses comma space separator instead of just comma #6361

sunlili commented Dec 22, 2019 •

edited

rhuanjl commented Mar 25, 2020

muhdmud commented Jul 28, 2020

ppenzin commented Aug 21, 2020

muhdmud commented Aug 24, 2020

muhdmud commented Aug 30, 2020 •

edited

ppenzin commented Sep 3, 2020

microsoft / ChakraCore

Join GitHub today

Array.prototype.toLocaleString uses comma space separator instead of just comma #6361

Array.prototype.toLocaleString uses comma space separator instead of just comma #6361

Comments

sunlili commented Dec 22, 2019 • edited

rhuanjl commented Mar 25, 2020

muhdmud commented Jul 28, 2020

ppenzin commented Aug 21, 2020

muhdmud commented Aug 24, 2020

muhdmud commented Aug 30, 2020 • edited

ppenzin commented Sep 3, 2020

sunlili commented Dec 22, 2019 •

edited

muhdmud commented Aug 30, 2020 •

edited