Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upadd custom id property for editor #58
Open
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
faradaytrs commentedMar 11, 2019
This is the same pull request, but without updating dependencies.
This PR allows us to pass an id prop when creating an editor. The previous implementation always used editor for the id which worked but caused issues when creating multiple editors on one page.
This PR fixes the issue by letting us pass a unique id prop to each editor, if no id prop is passed, the default is editor.
Simplified example of multiple editors: