Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSync with upstream @ ff152b12 #31
Open
Conversation
`openRequest.result.version` in `onupgradeneeded` is not the current DB version. It is the requested version, equal to `event.newVersion`. `event.oldVersion` contains the current version.
Fixed onupgradeneeded handling
Testcases/function object 5
Calling throttle before setting the fake timers will break any implementations that save a timestamp outside the wrapper function.
Set fake timers before calling throttle
Add bottom and right properties for getCoords()
followed -> followed by
Fix typo
Correct misspelling retarteted -> retargeted
Was tempted to suggest something a bit wordier: "where it finds it and, in this case, changes it", but I thought this would do.
Fixing a typo
without -> with
minor type fixes
minor typo fix
There are some missing "=" sign according to the question.
2 small fixes
Fix minor typo error: delete blank
Thank you!
Restructure the Solution for 'Army of Functions' task and Fix Typos
Fix javascript-tutorial#2090 - Spelling Mistake Close javascript-tutorial#2079 - Remove 'elem' from `elem.scrollLeft/scrollTop`
Some Corrections
Fix javascript-tutorial#2098 - replace let with var in IIFE example
Improve 'long polling' article. Complements #2073.
Corrected spelling of "representation"
Update article.md
Sync safe Number borders across chapter 1.2.5
Update article.md
Fix typo in 1.2.6
Update article.md
CLAassistant
commented
Sep 14, 2020
•
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
and others
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
javascript-translate-bot commentedSep 14, 2020
This PR was automatically generated to merge changes from en.javascript.info at ff152b1
Conflicted files in this PR have labels ">>>..." with both sides of conflict. If you merge this PR, you'll need to examine the listed files and resolve conflicts.
Alternatively, you can close this PR and merge conflicting changes manually.
The following files have conflicts and may need updates of the translations:
To merge changes manually (instead of merging this PR):
git add remote upstream https://github.com/javascript-tutorial/en.javascript.infogit checkout mastergit pull upstream mastergit checkout --ours <path>git diff --word-diff master...upstream/master <path>(please note: three dots in the command)git push origin masterThis PR will be closed and replaced with a new one in a few days.