Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upsome clippy clean ups #81
Open
Conversation
|
Thanks for the change. Please see comments. |
| @@ -5,7 +5,7 @@ use std::fs::File; | |||
| use std::io::Read; | |||
| use std::mem::swap; | |||
| use std::path::{Path, PathBuf}; | |||
| use syn; | |||
| // use syn; | |||
This comment has been minimized.
This comment has been minimized.
| @@ -31,7 +31,7 @@ impl<'a> Cursor<'a> { | |||
| + self.rest[..amt] | |||
| .char_indices() | |||
| .filter(|&(_, ref x)| *x == '\n') | |||
| .map(|(i, _)| column_start = Some(i)) | |||
| .filter(|(i, _)| { column_start = Some(*i); true } ) | |||
This comment has been minimized.
This comment has been minimized.
ogoffart
Jun 29, 2020
Collaborator
That's strange. I prefered how the code looked before. What's the rationale here? Is it because clippy complains that this should be a filrer_map? I guess then the warning should be ignored because filter does not make sense here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ahmed-masud commentedJun 28, 2020
No description provided.